diff options
| author |   Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-04 14:29:16 -0500 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2019-10-10 23:42:45 +1100 |
| commit | ffdde5932042600c6807d46c1550b28b0db6a3bc (patch) | |
| tree | f9e56b0a2489dcbc774a218e9c6c8eae17dcff74 | |
| parent | crypto: af_alg - cast ki_complete ternary op to int (diff) | |
| download | linux-dev-ffdde5932042600c6807d46c1550b28b0db6a3bc.tar.xz linux-dev-ffdde5932042600c6807d46c1550b28b0db6a3bc.zip | |
crypto: user - fix memory leak in crypto_report
In crypto_report, a new skb is created via nlmsg_new(). This skb should
be released if crypto_report_alg() fails.
Fixes: a38f7907b926 ("crypto: Add userspace configuration API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | crypto/crypto_user_base.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_base.c b/crypto/crypto_user_base.c index 910e0b46012e..b785c476de67 100644 --- a/crypto/crypto_user_base.c +++ b/crypto/crypto_user_base.c @@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, drop_alg: crypto_mod_put(alg); - if (err) + if (err) { + kfree_skb(skb); return err; + } return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid); } |