aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>2022-01-04 15:36:15 +0000
committerBartosz Golaszewski <brgl@bgdev.pl>2022-01-05 09:57:34 +0100
commitffe31c9ed35d70069ee76d6b6d41ac86a17d7a07 (patch)
treef0a757107212001ccd402522a866c1525b059c20
parentgpio: rcar: Use platform_get_irq() to get the interrupt (diff)
downloadlinux-dev-ffe31c9ed35d70069ee76d6b6d41ac86a17d7a07.tar.xz
linux-dev-ffe31c9ed35d70069ee76d6b6d41ac86a17d7a07.zip
gpio: rcar: Propagate errors from devm_request_irq()
The driver overrides the error code returned by devm_request_irq() to -ENOENT. Switch to propagating the error code upstream. Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
-rw-r--r--drivers/gpio/gpio-rcar.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 437baecc434e..bd2e16d6e21c 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
goto err0;
}
- if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
- IRQF_SHARED, name, p)) {
+ ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
+ IRQF_SHARED, name, p);
+ if (ret) {
dev_err(dev, "failed to request IRQ\n");
- ret = -ENOENT;
goto err1;
}