diff options
author | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2020-02-07 19:07:37 -0500 |
---|---|---|
committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2020-02-10 12:07:42 -0500 |
commit | f61872bb58a1cd8f0422aab1940eeee8be579d38 (patch) | |
tree | 0ec19f4ea031f697c2729879cb88cd58f8270623 /Documentation/admin-guide/cpu-load.rst | |
parent | tracing/kprobe: Fix uninitialized variable bug (diff) | |
download | linux-dev-f61872bb58a1cd8f0422aab1940eeee8be579d38.tar.xz linux-dev-f61872bb58a1cd8f0422aab1940eeee8be579d38.zip |
bootconfig: Use parse_args() to find bootconfig and '--'
The current implementation does a naive search of "bootconfig" on the kernel
command line. But this could find "bootconfig" that is part of another
option in quotes (although highly unlikely). But it also needs to find '--'
on the kernel command line to know if it should append a '--' or not when a
bootconfig in the initrd file has an "init" section. The check uses the
naive strstr() to find to see if it exists. But this can return a false
positive if it exists in an option and then the "init" section in the initrd
will not be appended properly.
Using parse_args() to find both of these will solve both of these problems.
Link: https://lore.kernel.org/r/202002070954.C18E7F58B@keescook
Fixes: 7495e0926fdf3 ("bootconfig: Only load bootconfig if "bootconfig" is on the kernel cmdline")
Fixes: 1319916209ce8 ("bootconfig: init: Allow admin to use bootconfig for init command line")
Reported-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'Documentation/admin-guide/cpu-load.rst')
0 files changed, 0 insertions, 0 deletions