diff options
| author |   Daniel Latypov <dlatypov@google.com> | 2022-05-13 11:37:07 -0700 |
|---|---|---|
| committer |   Shuah Khan <skhan@linuxfoundation.org> | 2022-05-17 10:01:40 -0600 |
| commit | 1b11063d32d7e11366e48be64215ff517ce32217 (patch) | |
| tree | 98fc3a63aded162a086d8cece4fa1f3ce1b719fc /Documentation/dev-tools/kunit | |
| parent | kunit: tool: update riscv QEMU config with new serial dependency (diff) | |
| download | linux-dev-1b11063d32d7e11366e48be64215ff517ce32217.tar.xz linux-dev-1b11063d32d7e11366e48be64215ff517ce32217.zip | |
kunit: fix executor OOM error handling logic on non-UML
The existing logic happens to work fine on UML, but is not correct when
running on other arches.
1. We didn't initialize `int err`, and kunit_filter_suites() doesn't
explicitly set it to 0 on success. So we had false "failures".
Note: it doesn't happen on UML, causing this to get overlooked.
2. If we error out, we do not call kunit_handle_shutdown().
This makes kunit.py timeout when using a non-UML arch, since the QEMU
process doesn't ever exit.
Fixes: a02353f49162 ("kunit: bail out of test filtering logic quicker if OOM")
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'Documentation/dev-tools/kunit')
0 files changed, 0 insertions, 0 deletions