diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2020-07-23 18:02:27 +0100 |
|---|---|---|
| committer |   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2020-09-08 13:33:03 +0200 |
| commit | c72fab81ceaa54408b827a2f0486d9a0f4be34cf (patch) | |
| tree | 933dfb217b7de3e3ca53feda947a6ec1ffc751d4 /Documentation/devicetree/bindings/display/ssd1307fb.txt | |
| parent | fbdev: sm712fb: handle ioremap() errors in probe (diff) | |
| download | linux-dev-c72fab81ceaa54408b827a2f0486d9a0f4be34cf.tar.xz linux-dev-c72fab81ceaa54408b827a2f0486d9a0f4be34cf.zip | |
video: fbdev: vga16fb: fix setting of pixclock because a pass-by-value error
The pixclock is being set locally because it is being passed as a
pass-by-value argument rather than pass-by-reference, so the computed
pixclock is never being set in var->pixclock. Fix this by passing
by reference.
[This dates back to 2002, I found the offending commit from the git
history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git ]
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
[b.zolnierkie: minor patch summary fixup]
[b.zolnierkie: removed "Fixes:" tag (not in upstream tree)]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200723170227.996229-1-colin.king@canonical.com
Diffstat (limited to 'Documentation/devicetree/bindings/display/ssd1307fb.txt')
0 files changed, 0 insertions, 0 deletions