diff options
| author |   Armin Wolf <W_Armin@gmx.de> | 2022-04-07 12:13:12 +0200 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2022-04-08 08:39:03 -0700 |
| commit | 7b2666ce445c700b8dcee994da44ddcf050a0842 (patch) | |
| tree | 9e559823eeef5457d353980d7787b368af281caf /Documentation/devicetree/bindings/hwmon | |
| parent | hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name (diff) | |
| download | linux-dev-7b2666ce445c700b8dcee994da44ddcf050a0842.tar.xz linux-dev-7b2666ce445c700b8dcee994da44ddcf050a0842.zip | |
hwmon: (adt7470) Fix warning on module removal
When removing the adt7470 module, a warning might be printed:
do not call blocking ops when !TASK_RUNNING; state=1
set at [<ffffffffa006052b>] adt7470_update_thread+0x7b/0x130 [adt7470]
This happens because adt7470_update_thread() can leave the kthread in
TASK_INTERRUPTIBLE state when the kthread is being stopped before
the call of set_current_state(). Since kthread_exit() might sleep in
exit_signals(), the warning is printed.
Fix that by using schedule_timeout_interruptible() and removing
the call of set_current_state().
This causes TASK_INTERRUPTIBLE to be set after kthread_should_stop()
which might cause the kthread to exit.
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Fixes: 93cacfd41f82 (hwmon: (adt7470) Allow faster removal)
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Zheyu Ma <zheyuma97@gmail.com>
Link: https://lore.kernel.org/r/20220407101312.13331-1-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'Documentation/devicetree/bindings/hwmon')
0 files changed, 0 insertions, 0 deletions