diff options
| author |   Vasiliy Kulikov <segoon@openwall.com> | 2010-11-14 07:06:08 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2010-11-17 12:27:46 -0800 |
| commit | dda0b38692a7298f433b92b1329867b1ecabb4bb (patch) | |
| tree | 87e070e4d51fe128214c838f534afe1c28178f19 /Documentation/leds-lp3944.txt | |
| parent | net: zero kobject in rx_queue_release (diff) | |
| download | linux-dev-dda0b38692a7298f433b92b1329867b1ecabb4bb.tar.xz linux-dev-dda0b38692a7298f433b92b1329867b1ecabb4bb.zip | |
net: ipv4: tcp_probe: cleanup snprintf() use
snprintf() returns number of bytes that were copied if there is no overflow.
This code uses return value as number of copied bytes. Theoretically format
string '%lu.%09lu %pI4:%u %pI4:%u %d %#x %#x %u %u %u %u\n' may be expanded
up to 163 bytes. In reality tv.tv_sec is just few bytes instead of 20, 2 ports
are just 5 bytes each instead of 10, length is 5 bytes instead of 10. The rest
is an unstrusted input. Theoretically if tv_sec is big then copy_to_user() would
overflow tbuf.
tbuf was increased to fit in 163 bytes. snprintf() is used to follow return
value semantic.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/leds-lp3944.txt')
0 files changed, 0 insertions, 0 deletions