diff options
| author |   Jesper Juhl <jj@chaosbits.net> | 2011-03-14 04:05:56 -0700 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@suse.de> | 2011-03-23 11:36:20 -0500 |
| commit | 6d1802539d218e24492c651bd0687ebfe7e14831 (patch) | |
| tree | 133b05930d8272259693c1e8bcce5ce1c8d98f1b /Documentation | |
| parent | [SCSI] target: Fix memory leak on error path in pscsi_alloc_task (diff) | |
| download | linux-dev-6d1802539d218e24492c651bd0687ebfe7e14831.tar.xz linux-dev-6d1802539d218e24492c651bd0687ebfe7e14831.zip | |
[SCSI] target: Fix match_strdup() memory leaks
match_strdup() dynamically allocates memory and it is the responsabillity
of the caller to free that memory. The following three cases:
drivers/target/target_core_file.c:fd_set_configfs_dev_params()
drivers/target/target_core_iblock.c:iblock_set_configfs_dev_params()
drivers/target/target_core_configfs.c:target_core_dev_pr_store_attr_res_aptpl_metadata()
should be kfree()'ing the allocated memory once it is no longer needed.
It also makes sure to return -ENOMEM if the memory allocation in match_strdup()
should fail. For target_core_configfs.c, this patch adds kfree()'s around
Opt_initiator_fabric, Opt_initiator_node, Opt_initiator_sid, Opt_sa_res_key,
Opt_target_fabric, and Opt_target_node for the Persistent Reservations
Activate Persistence across Target Power Loss (APTPL=1) token parsing.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions