diff options
| author |   Jesper Juhl <jesper.juhl@gmail.com> | 2007-11-11 23:57:49 +0100 |
|---|---|---|
| committer |   Vlad Yasevich <vladislav.yasevich@hp.com> | 2007-11-12 10:13:24 -0500 |
| commit | 9abed245a6dc94c32b2f45a1ecc51a0829d11470 (patch) | |
| tree | 2eeb675c127afb5b92646f7a27ad434438018994 /Documentation | |
| parent | SCTP: Always flush the queue when uncorcking. (diff) | |
| download | linux-dev-9abed245a6dc94c32b2f45a1ecc51a0829d11470.tar.xz linux-dev-9abed245a6dc94c32b2f45a1ecc51a0829d11470.zip | |
Fix memory leak in discard case of sctp_sf_abort_violation()
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
"sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to
the 'discard' label.
Spotted by the Coverity checker.
The simple fix is to simply move the creation of the "abort chunk"
to after the possible jump to the 'discard' label. This way we don't
even have to allocate the memory at all in the problem case.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions