diff options
| author |   Scott Feldman <sfeldma@gmail.com> | 2015-08-12 18:45:25 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-08-13 17:05:46 -0700 |
| commit | dd19f83d6cd90e4b7a601da2ed40d2a9d70aaf10 (patch) | |
| tree | fc079b90a3c0b45de5cd37b969a776cd4d4ed958 /Documentation | |
| parent | rocker: print switch ID consistent with phys_switch_id sysfs node (diff) | |
| download | linux-dev-dd19f83d6cd90e4b7a601da2ed40d2a9d70aaf10.tar.xz linux-dev-dd19f83d6cd90e4b7a601da2ed40d2a9d70aaf10.zip | |
rocker: hook ndo_neigh_destroy to cleanup neigh refs in driver
Rocker driver tracks arp_tbl neighs to resolve IPv4 route nexthops. The
driver uses NETEVENT_NEIGH_UPDATE for neigh adds and updates, but there is
no event when the neigh is removed from the device (such as when the device
goes admin down). This patches hooks ndo_neigh_destroy so the driver can
know when a neigh is removed from the device. In response, the driver will
purge the neigh entry from its internal tbl.
I didn't find an in-tree users of ndo_neigh_destroy, so I'm not sure if
this ndo is vestigial or if there are out-of-tree users. In any case, it
does what I need here. An alternative design would be to generate
NETEVENT_NEIGH_UPDATE event when neigh is being destroyed, setting state to
NUD_NONE so driver knows neigh entry is dead.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/networking/switchdev.txt | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 9825f32a8634..476df0496686 100644 --- a/Documentation/networking/switchdev.txt +++ b/Documentation/networking/switchdev.txt @@ -367,4 +367,5 @@ driver's rocker_port_ipv4_resolve() for an example. The driver can monitor for updates to arp_tbl using the netevent notifier NETEVENT_NEIGH_UPDATE. The device can be programmed with resolved nexthops -for the routes as arp_tbl updates. +for the routes as arp_tbl updates. The driver implements ndo_neigh_destroy +to know when arp_tbl neighbor entries are purged from the port. |