diff options
| author |   Calvin Walton <calvin.walton@kepstin.ca> | 2021-04-28 17:09:16 +0800 |
|---|---|---|
| committer |   Len Brown <len.brown@intel.com> | 2021-05-04 18:33:41 -0400 |
| commit | 13a779de4175df602366d129e41782ad7168cef0 (patch) | |
| tree | 8405a2d05e136f55d667267ecb047f9e29ef96bc /MAINTAINERS | |
| parent | tools/power/turbostat: Fix turbostat for AMD Zen CPUs (diff) | |
| download | linux-dev-13a779de4175df602366d129e41782ad7168cef0.tar.xz linux-dev-13a779de4175df602366d129e41782ad7168cef0.zip | |
tools/power turbostat: Fix offset overflow issue in index converting
The idx_to_offset() function returns type int (32-bit signed), but
MSR_PKG_ENERGY_STAT is u32 and would be interpreted as a negative number.
The end result is that it hits the if (offset < 0) check in update_msr_sum()
which prevents the timer callback from updating the stat in the background when
long durations are used. The similar issue exists in offset_to_idx() and
update_msr_sum(). Fix this issue by converting the 'int' to 'off_t' accordingly.
Fixes: 9972d5d84d76 ("tools/power turbostat: Enable accumulate RAPL display")
Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions