diff options
| author |   Eric Dumazet <edumazet@google.com> | 2020-01-06 06:10:39 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-01-08 12:40:47 -0800 |
| commit | d9e15a2733067c9328fb56d98fe8e574fa19ec31 (patch) | |
| tree | fcba680930ee393e0c16aa75b782975674cba89c /MAINTAINERS | |
| parent | tipc: remove meaningless assignment in Makefile (diff) | |
| download | linux-dev-d9e15a2733067c9328fb56d98fe8e574fa19ec31.tar.xz linux-dev-d9e15a2733067c9328fb56d98fe8e574fa19ec31.zip | |
pkt_sched: fq: do not accept silly TCA_FQ_QUANTUM
As diagnosed by Florian :
If TCA_FQ_QUANTUM is set to 0x80000000, fq_deueue()
can loop forever in :
if (f->credit <= 0) {
f->credit += q->quantum;
goto begin;
}
... because f->credit is either 0 or -2147483648.
Let's limit TCA_FQ_QUANTUM to no more than 1 << 20 :
This max value should limit risks of breaking user setups
while fixing this bug.
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Diagnosed-by: Florian Westphal <fw@strlen.de>
Reported-by: syzbot+dc9071cc5a85950bdfce@syzkaller.appspotmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions