aboutsummaryrefslogtreecommitdiffstats
path: root/Makefile
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-07-25 22:08:09 +0200
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-07-30 13:20:20 -0400
commit53e6d8d182e97c5211da4ee1f163c840c7ecf8ca (patch)
tree5f7eb6582c6dd05fa63aed15366198de7bbc6f40 /Makefile
parentMAINTAINERS: mention lockd and sunrpc in nfs entries (diff)
downloadlinux-dev-53e6d8d182e97c5211da4ee1f163c840c7ecf8ca.tar.xz
linux-dev-53e6d8d182e97c5211da4ee1f163c840c7ecf8ca.zip
fs/nfsd/export.c: Adjust error handling code involving auth_domain_put
Once clp is assigned, it never becomes NULL, so we can make a label for it in the error handling code. Because the call to path_lookup follows the call to auth_domain_find, its error handling code should jump to this new label. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r@ expression x,E; statement S; position p1,p2,p3; @@ ( if ((x = auth_domain_find@p1(...)) == NULL || ...) S | x = auth_domain_find@p1(...) ... when != x if (x == NULL || ...) S ) <... if@p3 (...) { ... when != auth_domain_put(x) when != if (x) { ... auth_domain_put(x); ...} return@p2 ...; } ...> ( return x; | return 0; | x = E | E = x | auth_domain_put(x) ) @exists@ position r.p1,r.p2,r.p3; expression x; int ret != 0; statement S; @@ * x = auth_domain_find@p1(...) <... * if@p3 (...) S ...> * return@p2 \(NULL\|ret\); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions