diff options
| author |   Michael Ellerman <michael@ellerman.id.au> | 2005-09-01 11:29:19 +1000 |
|---|---|---|
| committer |   Jeff Garzik <jgarzik@pobox.com> | 2005-08-31 22:42:45 -0400 |
| commit | db5e8718eac0b8166d6fd05b1ed7f8114c243988 (patch) | |
| tree | e0adc928ffa6735e228c6fd2867381f8442875e7 /Makefile | |
| parent | [PATCH] iseries_veth: Simplify full-queue handling (diff) | |
| download | linux-dev-db5e8718eac0b8166d6fd05b1ed7f8114c243988.tar.xz linux-dev-db5e8718eac0b8166d6fd05b1ed7f8114c243988.zip | |
[PATCH] iseries_veth: Fix bogus counting of TX errors
There's a number of problems with the way iseries_veth counts TX errors.
Firstly it counts conditions which aren't really errors as TX errors. This
includes if we don't have a connection struct for the other LPAR, or if the
other LPAR is currently down (or just doesn't want to talk to us). Neither
of these should count as TX errors.
Secondly, it counts one TX error for each LPAR that fails to accept the packet.
This can lead to TX error counts higher than the total number of packets sent
through the interface. This is confusing for users.
This patch fixes that behaviour. The non-error conditions are no longer
counted, and we introduce a new and I think saner meaning to the TX counts.
If a packet is successfully transmitted to any LPAR then it is transmitted
and tx_packets is incremented by 1.
If there is an error transmitting a packet to any LPAR then that is counted
as one error, ie. tx_errors is incremented by 1.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions