aboutsummaryrefslogtreecommitdiffstats
path: root/arch/alpha/include/asm/io_trivial.h
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2020-05-26 10:47:49 -0400
committerMatt Turner <mattst88@gmail.com>2020-06-12 17:43:18 -0700
commit54505a1e2083fc54cbe8779b97479f969cd30a00 (patch)
tree6eb979f701f2ce4aaf7bcd4c95f64596d70fcb18 /arch/alpha/include/asm/io_trivial.h
parentalpha: remove unneeded semicolon in sys_eiger.c (diff)
downloadlinux-dev-54505a1e2083fc54cbe8779b97479f969cd30a00.tar.xz
linux-dev-54505a1e2083fc54cbe8779b97479f969cd30a00.zip
alpha: fix memory barriers so that they conform to the specification
The commits cd0e00c10672 and 92d7223a7423 broke boot on the Alpha Avanti platform. The patches move memory barriers after a write before the write. The result is that if there's iowrite followed by ioread, there is no barrier between them. The Alpha architecture allows reordering of the accesses to the I/O space, and the missing barrier between write and read causes hang with serial port and real time clock. This patch makes barriers confiorm to the specification. 1. We add mb() before readX_relaxed and writeX_relaxed - memory-barriers.txt claims that these functions must be ordered w.r.t. each other. Alpha doesn't order them, so we need an explicit barrier. 2. We add mb() before reads from the I/O space - so that if there's a write followed by a read, there should be a barrier between them. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Fixes: cd0e00c10672 ("alpha: io: reorder barriers to guarantee writeX() and iowriteX() ordering") Fixes: 92d7223a7423 ("alpha: io: reorder barriers to guarantee writeX() and iowriteX() ordering #2") Cc: stable@vger.kernel.org # v4.17+ Acked-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org> Signed-off-by: Matt Turner <mattst88@gmail.com>
Diffstat (limited to 'arch/alpha/include/asm/io_trivial.h')
0 files changed, 0 insertions, 0 deletions