diff options
| author |   Juan Gutierrez <jgutierrez@ti.com> | 2012-05-13 15:33:04 +0300 |
|---|---|---|
| committer |   Ohad Ben-Cohen <ohad@wizery.com> | 2012-05-13 16:09:39 +0300 |
| commit | 1d8a0e963ac532e038d93ab0d30bbfad072f3bf8 (patch) | |
| tree | 536607fafd1014ff9f189092944e7d023b08f93b /arch/arm/mach-omap2/mailbox.c | |
| parent | Linux 3.4-rc6 (diff) | |
| download | linux-dev-1d8a0e963ac532e038d93ab0d30bbfad072f3bf8.tar.xz linux-dev-1d8a0e963ac532e038d93ab0d30bbfad072f3bf8.zip | |
ARM: OMAP: enable mailbox irq per instance
The machine-specific omap2_mbox_startup is called only once
to initialize the whole mbox module, and as a result,
enabling the mbox irq at that point only works for the very first
mailbox instance opened.
Instead, this patch makes sure enable_irq() is called every
time a new mbox instance is opened. In addition, we're now
enabling the mbox's irq only after its notifier_block is registered,
to avoid possible race of receiving an interrupt without invoking
the user's notifier callback.
Signed-off-by: Juan Gutierrez <jgutierrez@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
[ohad@wizery.com: slightly reworded the commit log]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Diffstat (limited to 'arch/arm/mach-omap2/mailbox.c')
| -rw-r--r-- | arch/arm/mach-omap2/mailbox.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index 415a6f1cf419..f727034216a7 100644 --- a/arch/arm/mach-omap2/mailbox.c +++ b/arch/arm/mach-omap2/mailbox.c @@ -83,8 +83,6 @@ static int omap2_mbox_startup(struct omap_mbox *mbox) l = mbox_read_reg(MAILBOX_REVISION); pr_debug("omap mailbox rev %d.%d\n", (l & 0xf0) >> 4, (l & 0x0f)); - omap2_mbox_enable_irq(mbox, IRQ_RX); - return 0; } |