diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2012-04-30 16:53:11 +0000 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2012-10-04 10:19:51 +0200 |
| commit | 5f0cc6d16c0572bf5e9e65b6133ac415268c0720 (patch) | |
| tree | 2ae73652306c95eea1c7c328fff2452dd52201cd /arch/arm/mach-pxa | |
| parent | ARM: shark: fix shark_pci_init return code (diff) | |
| download | linux-dev-5f0cc6d16c0572bf5e9e65b6133ac415268c0720.tar.xz linux-dev-5f0cc6d16c0572bf5e9e65b6133ac415268c0720.zip | |
ARM: pxa: Wunused-result warning in viper board file
Calling kstrtoul requires checking the result. In case of
the viper_tpm_setup function, let's fail the __setup function
if the number was invalid.
Without this patch, building viper_defconfig results in:
arch/arm/mach-pxa/viper.c: In function 'viper_tpm_setup':
arch/arm/mach-pxa/viper.c:771:10: warning: ignoring return value of 'kstrtoul', declared with attribute warn_unused_result [-Wunused-result]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Zyngier <maz@misterjones.org>
Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: Eric Miao <eric.y.miao@gmail.com>
Diffstat (limited to 'arch/arm/mach-pxa')
| -rw-r--r-- | arch/arm/mach-pxa/viper.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/arm/mach-pxa/viper.c b/arch/arm/mach-pxa/viper.c index 130379fb9d0f..ac733e91f3e4 100644 --- a/arch/arm/mach-pxa/viper.c +++ b/arch/arm/mach-pxa/viper.c @@ -768,8 +768,7 @@ static unsigned long viper_tpm; static int __init viper_tpm_setup(char *str) { - strict_strtoul(str, 10, &viper_tpm); - return 1; + return strict_strtoul(str, 10, &viper_tpm) >= 0; } __setup("tpm=", viper_tpm_setup); |