diff options
| author |   Andrey Utkin <andrey.krieger.utkin@gmail.com> | 2014-07-17 18:58:06 +0300 |
|---|---|---|
| committer |   James Hogan <james.hogan@imgtec.com> | 2014-07-18 10:36:59 +0100 |
| commit | f93125ae17d1d259b5aba84016db260903822194 (patch) | |
| tree | 0b443d3b35d2e1a6585f91078168c72618267bff /arch/metag | |
| parent | metag: hugetlbpage: Remove null pointer checks that could never happen (diff) | |
| download | linux-dev-f93125ae17d1d259b5aba84016db260903822194.tar.xz linux-dev-f93125ae17d1d259b5aba84016db260903822194.zip | |
metag: cachepart: Fix failure check
[linux-3.16-rc5/arch/metag/kernel/cachepart.c:102]: (style) Checking if
unsigned variable 'thread_cache_size' is less than zero.
Source code is
if (thread_cache_size < 0)
pr_emerg("Can't read %s cache size\n",
cache_type ? "DCACHE" : "ICACHE");
but
unsigned int thread_cache_size;
Function get_thread_cache_size returns an error code
as (unsigned int) -1.
Change get_thread_cache_size() to return signed int, and its result is
stored into signed int variable.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80361
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Diffstat (limited to 'arch/metag')
| -rw-r--r-- | arch/metag/kernel/cachepart.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/metag/kernel/cachepart.c b/arch/metag/kernel/cachepart.c index 0a2385fa2a1d..04b7d4f8429a 100644 --- a/arch/metag/kernel/cachepart.c +++ b/arch/metag/kernel/cachepart.c @@ -55,7 +55,7 @@ unsigned int get_global_icache_size(void) return (get_icache_size() * ((temp >> SYSC_xCPARTG_AND_S) + 1)) >> 4; } -static unsigned int get_thread_cache_size(unsigned int cache, int thread_id) +static int get_thread_cache_size(unsigned int cache, int thread_id) { unsigned int cache_size; unsigned int t_cache_part; @@ -94,7 +94,7 @@ static unsigned int get_thread_cache_size(unsigned int cache, int thread_id) void check_for_cache_aliasing(int thread_id) { - unsigned int thread_cache_size; + int thread_cache_size; unsigned int cache_type; for (cache_type = ICACHE; cache_type <= DCACHE; cache_type++) { thread_cache_size = |