diff options
| author |   Will Deacon <will.deacon@arm.com> | 2019-02-22 13:37:21 +0000 |
|---|---|---|
| committer | Will Deacon <will.deacon@arm.com> | 2019-04-08 12:00:28 +0100 |
| commit | 346e91ee090b07da8d15e36bc3169ddea6968713 (patch) | |
| tree | 8ec14892fbf565049c4ffa4a23d628514da4e991 /arch/mips/include/asm/io.h | |
| parent | sh/mmiowb: Add unconditional mmiowb() to arch_spin_unlock() (diff) | |
| download | linux-dev-346e91ee090b07da8d15e36bc3169ddea6968713.tar.xz linux-dev-346e91ee090b07da8d15e36bc3169ddea6968713.zip | |
mips/mmiowb: Add unconditional mmiowb() to arch_spin_unlock()
The mmiowb() macro is horribly difficult to use and drivers will continue
to work most of the time if they omit a call when it is required.
Rather than rely on driver authors getting this right, push mmiowb() into
arch_spin_unlock() for mips. If this is deemed to be a performance issue,
a subsequent optimisation could make use of ARCH_HAS_MMIOWB to elide
the barrier in cases where no I/O writes were performed inside the
critical section.
Acked-by: Paul Burton <paul.burton@mips.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'arch/mips/include/asm/io.h')
| -rw-r--r-- | arch/mips/include/asm/io.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h index 845fbbc7a2e3..29997e42480e 100644 --- a/arch/mips/include/asm/io.h +++ b/arch/mips/include/asm/io.h @@ -102,9 +102,6 @@ static inline void set_io_port_base(unsigned long base) #define iobarrier_w() wmb() #define iobarrier_sync() iob() -/* Some callers use this older API instead. */ -#define mmiowb() iobarrier_w() - /* * virt_to_phys - map virtual addresses to physical * @address: address to remap |