diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2017-01-18 19:00:05 +0100 |
|---|---|---|
| committer |   Ralf Baechle <ralf@linux-mips.org> | 2017-01-25 02:51:11 +0100 |
| commit | fcf4aec13b56edcfc837fa138d8b1d99b26e5ce4 (patch) | |
| tree | aa5ecc52464f31f864991ef9c0dd4fe9a038bf33 /arch/mips/kernel/linux32.c | |
| parent | MIPS: Avoid old-style declaration (diff) | |
| download | linux-dev-fcf4aec13b56edcfc837fa138d8b1d99b26e5ce4.tar.xz linux-dev-fcf4aec13b56edcfc837fa138d8b1d99b26e5ce4.zip | |
MIPS: Return directly in 32_mmap2()
* Return a failure indication without storing it
in an intermediate variable.
* Delete the local variable "error" which became unnecessary
with this refactoring.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-mips@linux-mips.org
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/15071/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/kernel/linux32.c')
| -rw-r--r-- | arch/mips/kernel/linux32.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c index 0352f742d077..b01bdef101a8 100644 --- a/arch/mips/kernel/linux32.c +++ b/arch/mips/kernel/linux32.c @@ -64,15 +64,10 @@ SYSCALL_DEFINE6(32_mmap2, unsigned long, addr, unsigned long, len, unsigned long, prot, unsigned long, flags, unsigned long, fd, unsigned long, pgoff) { - unsigned long error; - - error = -EINVAL; if (pgoff & (~PAGE_MASK >> 12)) - goto out; - error = sys_mmap_pgoff(addr, len, prot, flags, fd, - pgoff >> (PAGE_SHIFT-12)); -out: - return error; + return -EINVAL; + return sys_mmap_pgoff(addr, len, prot, flags, fd, + pgoff >> (PAGE_SHIFT-12)); } #define RLIM_INFINITY32 0x7fffffff |