aboutsummaryrefslogtreecommitdiffstats
path: root/arch/mips/mm/tlb-r3k.c
diff options
context:
space:
mode:
authorEmil Goode <emilgoode@gmail.com>2014-07-06 01:23:58 +0200
committerRalf Baechle <ralf@linux-mips.org>2014-07-30 20:59:43 +0200
commite5cd534a3125af4aaa2feb7de9f7700d0a8e91d1 (patch)
tree7485269311bbc78ed6af2ed2fc8a8ac41fed54fc /arch/mips/mm/tlb-r3k.c
parentMIPS: smp-cps: Fix entry code cache flush for systems with coherent I/O (diff)
downloadlinux-dev-e5cd534a3125af4aaa2feb7de9f7700d0a8e91d1.tar.xz
linux-dev-e5cd534a3125af4aaa2feb7de9f7700d0a8e91d1.zip
MIPS: Remove incorrect NULL check in local_flush_tlb_page()
We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent was to make sure vma is not NULL but this is not necessary since the bug pre-dates GIT history and seem to never have caused a problem. The tlb-4k and tlb-8k versions of local_flush_tlb_page() don't bother checking if vma is NULL, also vma is dereferenced before being passed to local_flush_tlb_page(), thus it is safe to remove this NULL check. Signed-off-by: Emil Goode <emilgoode@gmail.com> Reviewed-by: Jonas Gorski <jogo@openwrt.org> Acked-by: Maciej W. Rozycki <macro@linux-mips.org> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: John Crispin <blogic@openwrt.org> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/7264/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/mm/tlb-r3k.c')
-rw-r--r--arch/mips/mm/tlb-r3k.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
index d657493ef561..4094bbd42adf 100644
--- a/arch/mips/mm/tlb-r3k.c
+++ b/arch/mips/mm/tlb-r3k.c
@@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
{
int cpu = smp_processor_id();
- if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
+ if (cpu_context(cpu, vma->vm_mm) != 0) {
unsigned long flags;
int oldpid, newpid, idx;