diff options
| author |   Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 22:41:42 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-01-25 18:02:09 +0100 |
| commit | eecdf59ad2fb90d8238a42e2ec41f165964349bb (patch) | |
| tree | c0f6f232ce2201a0ba9c0f9271ebe36a962f9a5b /arch/powerpc/sysdev/ppc4xx_gpio.c | |
| parent | blackfin: gpio: Be sure to clamp return value (diff) | |
| download | linux-dev-eecdf59ad2fb90d8238a42e2ec41f165964349bb.tar.xz linux-dev-eecdf59ad2fb90d8238a42e2ec41f165964349bb.zip | |
powerpc: ppc4cc/gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Anatolij Gustschin <agust@denx.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'arch/powerpc/sysdev/ppc4xx_gpio.c')
| -rw-r--r-- | arch/powerpc/sysdev/ppc4xx_gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c index fc65ad1b3293..d7a7ef135b9f 100644 --- a/arch/powerpc/sysdev/ppc4xx_gpio.c +++ b/arch/powerpc/sysdev/ppc4xx_gpio.c @@ -78,7 +78,7 @@ static int ppc4xx_gpio_get(struct gpio_chip *gc, unsigned int gpio) struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); struct ppc4xx_gpio __iomem *regs = mm_gc->regs; - return in_be32(®s->ir) & GPIO_MASK(gpio); + return !!(in_be32(®s->ir) & GPIO_MASK(gpio)); } static inline void |