diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2019-06-03 15:11:58 -0700 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2019-08-05 18:53:03 +1000 |
commit | 0df3e42167caaf9f8c7b64de3da40a459979afe8 (patch) | |
tree | 849eab1113ffc33bf1edcb28c8b844808d06b51b /arch/powerpc/sysdev | |
parent | powerpc/rtas: Unexport rtas_online_cpus_mask, rtas_offline_cpus_mask (diff) | |
download | linux-dev-0df3e42167caaf9f8c7b64de3da40a459979afe8.tar.xz linux-dev-0df3e42167caaf9f8c7b64de3da40a459979afe8.zip |
PCI: rpaphp: Avoid a sometimes-uninitialized warning
When building with -Wsometimes-uninitialized, clang warns:
drivers/pci/hotplug/rpaphp_core.c:243:14: warning: variable 'fndit' is
used uninitialized whenever 'for' loop exits because its condition is
false [-Wsometimes-uninitialized]
for (j = 0; j < entries; j++) {
^~~~~~~~~~~
drivers/pci/hotplug/rpaphp_core.c:256:6: note: uninitialized use occurs
here
if (fndit)
^~~~~
drivers/pci/hotplug/rpaphp_core.c:243:14: note: remove the condition if
it is always true
for (j = 0; j < entries; j++) {
^~~~~~~~~~~
drivers/pci/hotplug/rpaphp_core.c:233:14: note: initialize the variable
'fndit' to silence this warning
int j, fndit;
^
= 0
fndit is only used to gate a sprintf call, which can be moved into the
loop to simplify the code and eliminate the local variable, which will
fix this warning.
Fixes: 2fcf3ae508c2 ("hotplug/drc-info: Add code to search ibm,drc-info property")
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Acked-by: Joel Savitz <jsavitz@redhat.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://github.com/ClangBuiltLinux/linux/issues/504
Link: https://lore.kernel.org/r/20190603221157.58502-1-natechancellor@gmail.com
Diffstat (limited to 'arch/powerpc/sysdev')
0 files changed, 0 insertions, 0 deletions