diff options
| author |   Michael Ellerman <mpe@ellerman.id.au> | 2014-03-14 16:00:30 +1100 |
|---|---|---|
| committer |   Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2014-03-24 09:48:25 +1100 |
| commit | 58b5fb00498ddaaa3f6582751e9eb731189ee4c8 (patch) | |
| tree | 211bd7f808e0c8ce824232a43d5641f0d878af65 /arch/powerpc | |
| parent | powerpc/perf: Add lost exception workaround (diff) | |
| download | linux-dev-58b5fb00498ddaaa3f6582751e9eb731189ee4c8.tar.xz linux-dev-58b5fb00498ddaaa3f6582751e9eb731189ee4c8.zip | |
powerpc/perf: Reject EBB events which specify a sample_type
Although we already block EBB events which request sampling using
sample_period, technically it's possible for an event to set sample_type
but not sample_period.
Nothing terrible will happen if an EBB event does specify sample_type,
but it signals a major confusion on the part of userspace, and so we do
them the favor of rejecting it.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc')
| -rw-r--r-- | arch/powerpc/perf/core-book3s.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c index 53ac1b20e14d..1e095fd68b6c 100644 --- a/arch/powerpc/perf/core-book3s.c +++ b/arch/powerpc/perf/core-book3s.c @@ -503,8 +503,11 @@ static int ebb_event_check(struct perf_event *event) if (!leader->attr.pinned || !leader->attr.exclusive) return -EINVAL; - if (event->attr.inherit || event->attr.sample_period || - event->attr.enable_on_exec || event->attr.freq) + if (event->attr.freq || + event->attr.inherit || + event->attr.sample_type || + event->attr.sample_period || + event->attr.enable_on_exec) return -EINVAL; } |