diff options
| author |   Christian Borntraeger <borntraeger@de.ibm.com> | 2008-11-26 14:51:08 +0100 |
|---|---|---|
| committer |   Avi Kivity <avi@redhat.com> | 2008-12-31 16:55:03 +0200 |
| commit | 6692cef30b7caf7525ae99670cddbaf28f1f9d40 (patch) | |
| tree | 956c25e52ef23e7127bef18b8b53d82e5e62220d /arch/s390 | |
| parent | KVM: s390: Fix refcounting and allow module unload (diff) | |
| download | linux-dev-6692cef30b7caf7525ae99670cddbaf28f1f9d40.tar.xz linux-dev-6692cef30b7caf7525ae99670cddbaf28f1f9d40.zip | |
KVM: s390: Fix memory leak of vcpu->run
The s390 backend of kvm never calls kvm_vcpu_uninit. This causes
a memory leak of vcpu->run pages.
Lets call kvm_vcpu_uninit in kvm_arch_vcpu_destroy to free
the vcpu->run.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Carsten Otte <cotte@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/s390')
| -rw-r--r-- | arch/s390/kvm/kvm-s390.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 3db9e5d45a67..76f05ddaef10 100644 --- a/arch/s390/kvm/kvm-s390.c +++ b/arch/s390/kvm/kvm-s390.c @@ -198,6 +198,7 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) { VCPU_EVENT(vcpu, 3, "%s", "free cpu"); free_page((unsigned long)(vcpu->arch.sie_block)); + kvm_vcpu_uninit(vcpu); kfree(vcpu); } @@ -230,8 +231,7 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu) void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) { - /* kvm common code refers to this, but does'nt call it */ - BUG(); + /* Nothing todo */ } void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) |