diff options
| author |   Nadav Amit <namit@vmware.com> | 2018-10-05 13:27:16 -0700 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2018-10-06 15:52:15 +0200 |
| commit | 0474d5d9d2f7f3b11262f7bf87d0e7314ead9200 (patch) | |
| tree | 2c1c08457dba60d0b6508e74fb052bd725ae4a0f /arch/x86/kernel/macros.S | |
| parent | Merge branch 'core/core' into x86/build, to prevent conflicts (diff) | |
| download | linux-dev-0474d5d9d2f7f3b11262f7bf87d0e7314ead9200.tar.xz linux-dev-0474d5d9d2f7f3b11262f7bf87d0e7314ead9200.zip | |
x86/extable: Macrofy inline assembly code to work around GCC inlining bugs
As described in:
77b0bf55bc67: ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs")
GCC's inlining heuristics are broken with common asm() patterns used in
kernel code, resulting in the effective disabling of inlining.
The workaround is to set an assembly macro and call it from the inline
assembly block - which is also a minor cleanup for the exception table
code.
Text size goes up a bit:
text data bss dec hex filename
18162555 10226288 2957312 31346155 1de4deb ./vmlinux before
18162879 10226256 2957312 31346447 1de4f0f ./vmlinux after (+292)
But this allows the inlining of functions such as nested_vmx_exit_reflected(),
set_segment_reg(), __copy_xstate_to_user() which is a net benefit.
Tested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Nadav Amit <namit@vmware.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20181005202718.229565-2-namit@vmware.com
Link: https://lore.kernel.org/lkml/20181003213100.189959-9-namit@vmware.com/T/#u
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/kernel/macros.S')
| -rw-r--r-- | arch/x86/kernel/macros.S | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kernel/macros.S b/arch/x86/kernel/macros.S index 71d8b716b111..7baa40d5bf16 100644 --- a/arch/x86/kernel/macros.S +++ b/arch/x86/kernel/macros.S @@ -11,3 +11,4 @@ #include <asm/alternative-asm.h> #include <asm/bug.h> #include <asm/paravirt.h> +#include <asm/asm.h> |