diff options
| author |   Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> | 2021-01-27 21:24:56 +0900 |
|---|---|---|
| committer |   Borislav Petkov <bp@suse.de> | 2021-01-27 19:06:47 +0100 |
| commit | 02a16aa13574c8526beadfc9ae8cc9b66315fa2d (patch) | |
| tree | 36bcd705c1ceaa52cb9bcebab2192acbd079fcd0 /arch/x86/kernel/msr.c | |
| parent | selftests/fpu: Fix debugfs_simple_attr.cocci warning (diff) | |
| download | linux-dev-02a16aa13574c8526beadfc9ae8cc9b66315fa2d.tar.xz linux-dev-02a16aa13574c8526beadfc9ae8cc9b66315fa2d.zip | |
x86/MSR: Filter MSR writes through X86_IOC_WRMSR_REGS ioctl too
Commit
a7e1f67ed29f ("x86/msr: Filter MSR writes")
introduced a module parameter to disable writing to the MSR device file
and tainted the kernel upon writing. As MSR registers can be written by
the X86_IOC_WRMSR_REGS ioctl too, the same filtering and tainting should
be applied to the ioctl as well.
[ bp: Massage commit message and space out statements. ]
Fixes: a7e1f67ed29f ("x86/msr: Filter MSR writes")
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20210127122456.13939-1-misono.tomohiro@jp.fujitsu.com
Diffstat (limited to 'arch/x86/kernel/msr.c')
| -rw-r--r-- | arch/x86/kernel/msr.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index 8a67d1fa8dc5..ed8ac6bcbafb 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel/msr.c @@ -182,6 +182,13 @@ static long msr_ioctl(struct file *file, unsigned int ioc, unsigned long arg) err = security_locked_down(LOCKDOWN_MSR); if (err) break; + + err = filter_write(regs[1]); + if (err) + return err; + + add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK); + err = wrmsr_safe_regs_on_cpu(cpu, regs); if (err) break; |