diff options
| author |   Vegard Nossum <vegard.nossum@gmail.com> | 2008-08-20 18:18:26 +0200 |
|---|---|---|
| committer |   Ingo Molnar <mingo@elte.hu> | 2008-08-21 12:52:01 +0200 |
| commit | b2a6a58ca6a3ddf4e278a53199c5b8fd39adbc0e (patch) | |
| tree | 3febfb621e5f1364298e0389679540318aaa265b /arch/x86/kernel/numaq_32.c | |
| parent | x86: export pv_lock_ops non-GPL (diff) | |
| download | linux-dev-b2a6a58ca6a3ddf4e278a53199c5b8fd39adbc0e.tar.xz linux-dev-b2a6a58ca6a3ddf4e278a53199c5b8fd39adbc0e.zip | |
x86: fix BUG: unable to handle kernel paging request (numaq_tsc_disable)
This section mismatch:
>> Seems to be a section mismatch; init_intel() is __cpuinit while
>> numaq_tsc_disable() is __init. Seems to be introduced in:
>>
>> commit 64898a8bad8c94ad7a4bd5cc86b66edfbb081f4a
>> Author: Yinghai Lu <yhlu.kernel@gmail.com>
>> Date: Sat Jul 19 18:01:16 2008 -0700
>>
>> x86: extend and use x86_quirks to clean up NUMAQ code
>
> Oops, I am wrong about numaq_tsc_disable() being __init. Still, I
> believe that Yinghai might be able to say what's really wrong :-)
Would lead to this crash:
BUG: unable to handle kernel paging request at c08a45f0
IP: [<c08a45f0>] numaq_tsc_disable+0x0/0x40
Fixed by the patch below.
Signed-off-by: Vegard Nossum <vegardno@ifi.uio.no>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/numaq_32.c')
| -rw-r--r-- | arch/x86/kernel/numaq_32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/numaq_32.c b/arch/x86/kernel/numaq_32.c index b8c45610b20a..eecc8c18f010 100644 --- a/arch/x86/kernel/numaq_32.c +++ b/arch/x86/kernel/numaq_32.c @@ -73,7 +73,7 @@ static void __init smp_dump_qct(void) } -void __init numaq_tsc_disable(void) +void __cpuinit numaq_tsc_disable(void) { if (!found_numaq) return; |