diff options
| author |   Jiri Slaby <jslaby@suse.cz> | 2022-09-06 09:11:23 +0200 |
|---|---|---|
| committer |   Borislav Petkov <bp@suse.de> | 2022-09-20 16:11:54 +0200 |
| commit | 5258b80e60da6d8908ae2846b234ed8d9d9d4a19 (patch) | |
| tree | a34b2baea9bf165d3badd3f2cf7cb625b360fc86 /arch/x86/kernel | |
| parent | x86/Kconfig: Specify idle=poll instead of no-hlt (diff) | |
| download | linux-dev-5258b80e60da6d8908ae2846b234ed8d9d9d4a19.tar.xz linux-dev-5258b80e60da6d8908ae2846b234ed8d9d9d4a19.zip | |
x86/dumpstack: Don't mention RIP in "Code: "
Commit
238c91115cd0 ("x86/dumpstack: Fix misleading instruction pointer error message")
changed the "Code:" line in bug reports when RIP is an invalid pointer.
In particular, the report currently says (for example):
BUG: kernel NULL pointer dereference, address: 0000000000000000
...
RIP: 0010:0x0
Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
That
Unable to access opcode bytes at RIP 0xffffffffffffffd6.
is quite confusing as RIP value is 0, not -42. That -42 comes from
"regs->ip - PROLOGUE_SIZE", because Code is dumped with some prologue
(and epilogue).
So do not mention "RIP" on this line in this context.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/b772c39f-c5ae-8f17-fe6e-6a2bc4d1f83b@kernel.org
Diffstat (limited to 'arch/x86/kernel')
| -rw-r--r-- | arch/x86/kernel/dumpstack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index afae4dd77495..b3dba35f466e 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -128,7 +128,7 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl) /* No access to the user space stack of other tasks. Ignore. */ break; default: - printk("%sCode: Unable to access opcode bytes at RIP 0x%lx.\n", + printk("%sCode: Unable to access opcode bytes at 0x%lx.\n", loglvl, prologue); break; } |