diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2017-07-19 14:53:00 +0200 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2017-07-20 10:46:24 +0200 |
| commit | 75e2f0a6b16141cb347f442033ec907380d4d66e (patch) | |
| tree | 95da28d4ab0ea6a7d902f4c63c61f9f5cca8cc82 /arch/x86/math-emu/Makefile | |
| parent | perf/x86: Shut up false-positive -Wmaybe-uninitialized warning (diff) | |
| download | linux-dev-75e2f0a6b16141cb347f442033ec907380d4d66e.tar.xz linux-dev-75e2f0a6b16141cb347f442033ec907380d4d66e.zip | |
x86/fpu/math-emu: Fix possible uninitialized variable use
When building the kernel with "make EXTRA_CFLAGS=...", this overrides
the "PARANOID" preprocessor macro defined in arch/x86/math-emu/Makefile,
and we run into a build warning:
arch/x86/math-emu/reg_compare.c: In function ‘compare_i_st_st’:
arch/x86/math-emu/reg_compare.c:254:6: error: ‘f’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
This fixes the implementation to work correctly even without the PARANOID
flag, and also fixes the Makefile to not use the EXTRA_CFLAGS variable
but instead use the ccflags-y variable in the Makefile that is meant
for this purpose.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Bill Metzenthen <billm@melbpc.org.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170719125310.2487451-3-arnd@arndb.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/math-emu/Makefile')
| -rw-r--r-- | arch/x86/math-emu/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/math-emu/Makefile b/arch/x86/math-emu/Makefile index 9b0c63b60302..1b2dac174321 100644 --- a/arch/x86/math-emu/Makefile +++ b/arch/x86/math-emu/Makefile @@ -5,8 +5,8 @@ #DEBUG = -DDEBUGGING DEBUG = PARANOID = -DPARANOID -EXTRA_CFLAGS := $(PARANOID) $(DEBUG) -fno-builtin $(MATH_EMULATION) -EXTRA_AFLAGS := $(PARANOID) +ccflags-y += $(PARANOID) $(DEBUG) -fno-builtin $(MATH_EMULATION) +asflags-y += $(PARANOID) # From 'C' language sources: C_OBJS =fpu_entry.o errors.o \ |