diff options
| author |   Mark Rutland <mark.rutland@arm.com> | 2021-11-29 13:06:53 +0000 |
|---|---|---|
| committer |   Thomas Gleixner <tglx@linutronix.de> | 2021-12-01 00:06:43 +0100 |
| commit | dca99fb643a2e9bc2e67a0f626b09d4f177f0f09 (patch) | |
| tree | 55747d41170b37c93cd762186cc7210e19c82ce8 /arch/x86/mm/tlb.c | |
| parent | thread_info: Add helpers to snapshot thread flags (diff) | |
| download | linux-dev-dca99fb643a2e9bc2e67a0f626b09d4f177f0f09.tar.xz linux-dev-dca99fb643a2e9bc2e67a0f626b09d4f177f0f09.zip | |
x86: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled,
the flags can change under our feet. Generally this is unlikely to cause a
problem in practice, but it is somewhat unsound, and KCSAN will
legitimately warn that there is a data race.
To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.
Convert them all to the new flag accessor helpers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20211129130653.2037928-12-mark.rutland@arm.com
Diffstat (limited to 'arch/x86/mm/tlb.c')
| -rw-r--r-- | arch/x86/mm/tlb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 59ba2968af1b..92bb03b9ceb5 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -361,7 +361,7 @@ static void l1d_flush_evaluate(unsigned long prev_mm, unsigned long next_mm, static unsigned long mm_mangle_tif_spec_bits(struct task_struct *next) { - unsigned long next_tif = task_thread_info(next)->flags; + unsigned long next_tif = read_task_thread_flags(next); unsigned long spec_bits = (next_tif >> TIF_SPEC_IB) & LAST_USER_MM_SPEC_MASK; /* |