diff options
| author |   Avi Kivity <avi@qumranet.com> | 2008-08-22 19:19:38 +0300 |
|---|---|---|
| committer | Avi Kivity <avi@qumranet.com> | 2008-08-25 17:24:27 +0300 |
| commit | cd5998ebfbc9e6cb44408efa217c15d7eea13675 (patch) | |
| tree | d0ec4fa1d772c385ea71a1d5a5aa0646710ca3f7 /arch/x86 | |
| parent | KVM: Use .fixup instead of .text.fixup on __kvm_handle_fault_on_reboot (diff) | |
| download | linux-dev-cd5998ebfbc9e6cb44408efa217c15d7eea13675.tar.xz linux-dev-cd5998ebfbc9e6cb44408efa217c15d7eea13675.zip | |
KVM: MMU: Fix torn shadow pte
The shadow code assigns a pte directly in one place, which is nonatomic on
i386 can can cause random memory references. Fix by using an atomic setter.
Signed-off-by: Avi Kivity <avi@qumranet.com>
Diffstat (limited to 'arch/x86')
| -rw-r--r-- | arch/x86/kvm/paging_tmpl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h index f72ac1fa35f0..4a814bff21f2 100644 --- a/arch/x86/kvm/paging_tmpl.h +++ b/arch/x86/kvm/paging_tmpl.h @@ -345,7 +345,7 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr, shadow_addr = __pa(shadow_page->spt); shadow_pte = shadow_addr | PT_PRESENT_MASK | PT_ACCESSED_MASK | PT_WRITABLE_MASK | PT_USER_MASK; - *shadow_ent = shadow_pte; + set_shadow_pte(shadow_ent, shadow_pte); } mmu_set_spte(vcpu, shadow_ent, access, walker->pte_access & access, |