diff options
| author |   Max Filippov <jcmvbkbc@gmail.com> | 2019-04-04 11:08:40 -0700 |
|---|---|---|
| committer | Max Filippov <jcmvbkbc@gmail.com> | 2019-04-04 11:18:55 -0700 |
| commit | ada770b1e74a77fff2d5f539bf6c42c25f4784db (patch) | |
| tree | d16d2233df136a01200e44892352b6c3aa023be2 /arch/xtensa | |
| parent | xtensa: fix initialization of pt_regs::syscall in start_thread (diff) | |
| download | linux-dev-ada770b1e74a77fff2d5f539bf6c42c25f4784db.tar.xz linux-dev-ada770b1e74a77fff2d5f539bf6c42c25f4784db.zip | |
xtensa: fix return_address
return_address returns the address that is one level higher in the call
stack than requested in its argument, because level 0 corresponds to its
caller's return address. Use requested level as the number of stack
frames to skip.
This fixes the address reported by might_sleep and friends.
Cc: stable@vger.kernel.org
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Diffstat (limited to 'arch/xtensa')
| -rw-r--r-- | arch/xtensa/kernel/stacktrace.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/arch/xtensa/kernel/stacktrace.c b/arch/xtensa/kernel/stacktrace.c index 174c11f13bba..b9f82510c650 100644 --- a/arch/xtensa/kernel/stacktrace.c +++ b/arch/xtensa/kernel/stacktrace.c @@ -253,10 +253,14 @@ static int return_address_cb(struct stackframe *frame, void *data) return 1; } +/* + * level == 0 is for the return address from the caller of this function, + * not from this function itself. + */ unsigned long return_address(unsigned level) { struct return_addr_data r = { - .skip = level + 1, + .skip = level, }; walk_stackframe(stack_pointer(NULL), return_address_cb, &r); return r.addr; |