aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorLan Tianyu <tianyu.lan@intel.com>2016-03-13 11:10:29 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2016-03-22 16:38:35 +0100
commit0f127d12e44c13d2f90e5c613490e70ddb1a5e08 (patch)
tree5aef93f99803531d4672132610b9c56ca77e2ee0 /arch
parentKVM: Replace smp_mb() with smp_load_acquire() in the kvm_flush_remote_tlbs() (diff)
downloadlinux-dev-0f127d12e44c13d2f90e5c613490e70ddb1a5e08.tar.xz
linux-dev-0f127d12e44c13d2f90e5c613490e70ddb1a5e08.zip
KVM/x86: update the comment of memory barrier in the vcpu_enter_guest()
The barrier also orders the write to mode from any reads to the page tables done and so update the comment. Signed-off-by: Lan Tianyu <tianyu.lan@intel.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86/kvm/x86.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 98ae1fb9fd66..e260ccbc8f55 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -6596,8 +6596,12 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
- /* We should set ->mode before check ->requests,
- * see the comment in make_all_cpus_request.
+ /*
+ * We should set ->mode before check ->requests,
+ * Please see the comment in kvm_make_all_cpus_request.
+ * This also orders the write to mode from any reads
+ * to the page tables done while the VCPU is running.
+ * Please see the comment in kvm_flush_remote_tlbs.
*/
smp_mb__after_srcu_read_unlock();