diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-02-28 12:22:56 +0300 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2020-02-29 17:48:08 -0500 |
| commit | 37b0b6b8b99c0e1c1f11abbe7cf49b6d03795b3f (patch) | |
| tree | e5b072f6e69c2b726c70c865015763d395680d6a /arch | |
| parent | jbd2: fix data races at struct journal_head (diff) | |
| download | linux-dev-37b0b6b8b99c0e1c1f11abbe7cf49b6d03795b3f.tar.xz linux-dev-37b0b6b8b99c0e1c1f11abbe7cf49b6d03795b3f.zip | |
ext4: potential crash on allocation error in ext4_alloc_flex_bg_array()
If sbi->s_flex_groups_allocated is zero and the first allocation fails
then this code will crash. The problem is that "i--" will set "i" to
-1 but when we compare "i >= sbi->s_flex_groups_allocated" then the -1
is type promoted to unsigned and becomes UINT_MAX. Since UINT_MAX
is more than zero, the condition is true so we call kvfree(new_groups[-1]).
The loop will carry on freeing invalid memory until it crashes.
Fixes: 7c990728b99e ("ext4: fix potential race between s_flex_groups online resizing and access")
Reviewed-by: Suraj Jitindar Singh <surajjs@amazon.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20200228092142.7irbc44yaz3by7nb@kili.mountain
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions