diff options
| author |   Josh Poimboeuf <jpoimboe@redhat.com> | 2017-03-02 16:57:23 -0600 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2017-03-07 08:42:55 +0100 |
| commit | 5c51f4ae84df0f9df33ac08aa5be50061a8b4242 (patch) | |
| tree | 9e301e1fb51b970b742c6bf37e4f4ec622d1322c /arch | |
| parent | drivers/char/nwbutton: Fix build breakage caused by include file reshuffling (diff) | |
| download | linux-dev-5c51f4ae84df0f9df33ac08aa5be50061a8b4242.tar.xz linux-dev-5c51f4ae84df0f9df33ac08aa5be50061a8b4242.zip | |
objtool: Fix another GCC jump table detection issue
Arnd Bergmann reported a (false positive) objtool warning:
drivers/infiniband/sw/rxe/rxe_resp.o: warning: objtool: rxe_responder()+0xfe: sibling call from callable instruction with changed frame pointer
The issue is in find_switch_table(). It tries to find a switch
statement's jump table by walking backwards from an indirect jump
instruction, looking for a relocation to the .rodata section. In this
case it stopped walking prematurely: the first .rodata relocation it
encountered was for a variable (resp_state_name) instead of a jump
table, so it just assumed there wasn't a jump table.
The fix is to ignore any .rodata relocation which refers to an ELF
object symbol. This works because the jump tables are anonymous and
have no symbols associated with them.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 3732710ff6f2 ("objtool: Improve rare switch jump table pattern detection")
Link: http://lkml.kernel.org/r/20170302225723.3ndbsnl4hkqbne7a@treble
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions