diff options
| author |   Guo Ren <guoren@linux.alibaba.com> | 2021-05-04 14:08:44 +0800 |
|---|---|---|
| committer | Guo Ren <guoren@linux.alibaba.com> | 2021-07-04 17:39:54 +0800 |
| commit | 6ea42c84f33368eb3fe1ec1bff8d7cb1a5c7b07a (patch) | |
| tree | 8c651b03bd589f0f33c9060c03269b792d740c4f /arch | |
| parent | Linux 5.13-rc7 (diff) | |
| download | linux-dev-6ea42c84f33368eb3fe1ec1bff8d7cb1a5c7b07a.tar.xz linux-dev-6ea42c84f33368eb3fe1ec1bff8d7cb1a5c7b07a.zip | |
csky: syscache: Fixup duplicate cache flush
The current csky logic of sys_cacheflush is wrong, it'll cause
icache flush call dcache flush again. Now fixup it with a
conditional "break & fallthrough".
Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all")
Fixes: 0679d29d3e23 ("csky: fix syscache.c fallthrough warning")
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Co-Developed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/csky/mm/syscache.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c index 4e51d63850c4..cd847ad62c7e 100644 --- a/arch/csky/mm/syscache.c +++ b/arch/csky/mm/syscache.c @@ -12,15 +12,17 @@ SYSCALL_DEFINE3(cacheflush, int, cache) { switch (cache) { - case ICACHE: case BCACHE: - flush_icache_mm_range(current->mm, - (unsigned long)addr, - (unsigned long)addr + bytes); - fallthrough; case DCACHE: dcache_wb_range((unsigned long)addr, (unsigned long)addr + bytes); + if (cache != BCACHE) + break; + fallthrough; + case ICACHE: + flush_icache_mm_range(current->mm, + (unsigned long)addr, + (unsigned long)addr + bytes); break; default: return -EINVAL; |