diff options
| author |   Miaohe Lin <linmiaohe@huawei.com> | 2020-02-14 10:32:38 +0800 |
|---|---|---|
| committer |   Paolo Bonzini <pbonzini@redhat.com> | 2020-02-21 18:04:57 +0100 |
| commit | 7455a8327674e1a7c9a1f5dd1b0743ab6713f6d1 (patch) | |
| tree | a8d82e5c0c81b152017c6e4f696cbb40e5d0844d /arch | |
| parent | kvm/emulate: fix a -Werror=cast-function-type (diff) | |
| download | linux-dev-7455a8327674e1a7c9a1f5dd1b0743ab6713f6d1.tar.xz linux-dev-7455a8327674e1a7c9a1f5dd1b0743ab6713f6d1.zip | |
KVM: x86: don't notify userspace IOAPIC on edge-triggered interrupt EOI
Commit 13db77347db1 ("KVM: x86: don't notify userspace IOAPIC on edge
EOI") said, edge-triggered interrupts don't set a bit in TMR, which means
that IOAPIC isn't notified on EOI. And var level indicates level-triggered
interrupt.
But commit 3159d36ad799 ("KVM: x86: use generic function for MSI parsing")
replace var level with irq.level by mistake. Fix it by changing irq.level
to irq.trig_mode.
Cc: stable@vger.kernel.org
Fixes: 3159d36ad799 ("KVM: x86: use generic function for MSI parsing")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/kvm/irq_comm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c index 79afa0bb5f41..c47d2acec529 100644 --- a/arch/x86/kvm/irq_comm.c +++ b/arch/x86/kvm/irq_comm.c @@ -417,7 +417,7 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, kvm_set_msi_irq(vcpu->kvm, entry, &irq); - if (irq.level && + if (irq.trig_mode && kvm_apic_match_dest(vcpu, NULL, APIC_DEST_NOSHORT, irq.dest_id, irq.dest_mode)) __set_bit(irq.vector, ioapic_handled_vectors); |