aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2022-11-01 16:15:38 +0000
committerDavid Sterba <dsterba@suse.com>2022-11-02 17:43:28 +0100
commit92876eec382a0f19f33d09d2c939e9ca49038ae5 (patch)
tree7a333e9e54737dce7045bb61e2af422c515a8da5 /arch
parentbtrfs: fix inode list leak during backref walking at resolve_indirect_refs() (diff)
downloadlinux-dev-92876eec382a0f19f33d09d2c939e9ca49038ae5.tar.xz
linux-dev-92876eec382a0f19f33d09d2c939e9ca49038ae5.zip
btrfs: fix inode list leak during backref walking at find_parent_nodes()
During backref walking, at find_parent_nodes(), if we are dealing with a data extent and we get an error while resolving the indirect backrefs, at resolve_indirect_refs(), or in the while loop that iterates over the refs in the direct refs rbtree, we end up leaking the inode lists attached to the direct refs we have in the direct refs rbtree that were not yet added to the refs ulist passed as argument to find_parent_nodes(). Since they were not yet added to the refs ulist and prelim_release() does not free the lists, on error the caller can only free the lists attached to the refs that were added to the refs ulist, all the remaining refs get their inode lists never freed, therefore leaking their memory. Fix this by having prelim_release() always free any attached inode list to each ref found in the rbtree, and have find_parent_nodes() set the ref's inode list to NULL once it transfers ownership of the inode list to a ref added to the refs ulist passed to find_parent_nodes(). Fixes: 86d5f9944252 ("btrfs: convert prelimary reference tracking to use rbtrees") Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions