diff options
| author |   Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-01-21 11:48:49 +0900 |
|---|---|---|
| committer |   Paul Burton <paul.burton@mips.com> | 2019-01-22 17:35:57 -0800 |
| commit | a0f0b69f2c15c12eb45b4e8d76f704ba9bc9c126 (patch) | |
| tree | a19bb0313e39efc7497df951bb0e90d9b122dc74 /arch | |
| parent | MIPS: Loongson32: Revert ISA level to MIPS32R2 (diff) | |
| download | linux-dev-a0f0b69f2c15c12eb45b4e8d76f704ba9bc9c126.tar.xz linux-dev-a0f0b69f2c15c12eb45b4e8d76f704ba9bc9c126.zip | |
MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
This line is weird in multiple ways.
(CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
to 'y' because scripts/Makefile.asm-generic does not include
include/config/auto.conf. So, the asm-generic wrapper of checksum.h
is never generated.
Even if you manage to generate it, it is never included by anyone
because MIPS has the checkin header with the same file name:
arch/mips/include/asm/checksum.h
As you see in the top Makefile, the checkin headers are included before
generated ones.
LINUXINCLUDE := \
-I$(srctree)/arch/$(SRCARCH)/include \
-I$(objtree)/arch/$(SRCARCH)/include/generated \
...
Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
already added the asm-generic fallback code in the checkin header:
#ifdef CONFIG_GENERIC_CSUM
#include <asm/generic/checksum.h>
#else
...
#endif
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-kernel@vger.kernel.org
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/mips/include/asm/Kbuild | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild index f15d5db5dd67..87b86cdf126a 100644 --- a/arch/mips/include/asm/Kbuild +++ b/arch/mips/include/asm/Kbuild @@ -3,7 +3,6 @@ generated-y += syscall_table_32_o32.h generated-y += syscall_table_64_n32.h generated-y += syscall_table_64_n64.h generated-y += syscall_table_64_o32.h -generic-(CONFIG_GENERIC_CSUM) += checksum.h generic-y += current.h generic-y += device.h generic-y += dma-contiguous.h |