diff options
| author |   Yong Zhang <yong.zhang@windriver.com> | 2012-07-19 09:13:53 +0200 |
|---|---|---|
| committer |   Ralf Baechle <ralf@linux-mips.org> | 2012-07-19 11:23:44 +0200 |
| commit | b789ad63ac46b00f0862bdc23fc95556adc3cf2f (patch) | |
| tree | 2d096cf5770cc78f46584266bf4fbca92f339690 /arch | |
| parent | MIPS: call set_cpu_online() on cpu being brought up with irq disabled (diff) | |
| download | linux-dev-b789ad63ac46b00f0862bdc23fc95556adc3cf2f.tar.xz linux-dev-b789ad63ac46b00f0862bdc23fc95556adc3cf2f.zip | |
MIPS: smp: Warn on too early irq enable
Just to catch a potential issue.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <david.daney@cavium.com>
Acked-by: David Daney <david.daney@cavium.com>
Patchwork: https://patchwork.linux-mips.org/patch/3852/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/mips/kernel/smp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c index eb3e2b112a0d..1268392f1d27 100644 --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void) synchronise_count_slave(); + /* + * irq will be enabled in ->smp_finish(), enabling it too early + * is dangerous. + */ + WARN_ON_ONCE(!irqs_disabled()); mp_ops->smp_finish(); cpu_idle(); |