diff options
| author |   Ming Lei <ming.lei@redhat.com> | 2021-02-02 23:54:10 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2021-02-02 08:57:56 -0700 |
| commit | 8358c28a5d44bf0223a55a2334086c3707bb4185 (patch) | |
| tree | 3a0d5a95e466bf5467e61206c284ae95938af1a0 /block | |
| parent | md: use rdev_read_only in restart_array (diff) | |
| download | linux-dev-8358c28a5d44bf0223a55a2334086c3707bb4185.tar.xz linux-dev-8358c28a5d44bf0223a55a2334086c3707bb4185.zip | |
block: fix memory leak of bvec
bio_init() clears bio instance, so the bvec index has to be set after
bio_init(), otherwise bio->bi_io_vec may be leaked.
Fixes: 3175199ab0ac ("block: split bio_kmalloc from bio_alloc_bioset")
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/bio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/bio.c b/block/bio.c index d4375619348c..757fee46cefc 100644 --- a/block/bio.c +++ b/block/bio.c @@ -482,8 +482,8 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs, if (unlikely(!bvl)) goto err_free; - bio->bi_flags |= idx << BVEC_POOL_OFFSET; bio_init(bio, bvl, bvec_nr_vecs(idx)); + bio->bi_flags |= idx << BVEC_POOL_OFFSET; } else if (nr_iovecs) { bio_init(bio, bio->bi_inline_vecs, BIO_INLINE_VECS); } else { |