diff options
| author |   Christian Brauner <brauner@kernel.org> | 2022-02-03 14:14:11 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2022-02-14 08:37:40 +0100 |
| commit | 87bb5b60019c60e1f902e6885734cc4e5135c2d9 (patch) | |
| tree | 0617901debd5f10e521856457ceb6e943a6a9d4a /block | |
| parent | fs: don't open-code mnt_hold_writers() (diff) | |
| download | linux-dev-87bb5b60019c60e1f902e6885734cc4e5135c2d9.tar.xz linux-dev-87bb5b60019c60e1f902e6885734cc4e5135c2d9.zip | |
fs: clean up mount_setattr control flow
Simplify the control flow of mount_setattr_{prepare,commit} so they
become easier to follow. We kept using both an integer error variable
that was passed by pointer as well as a pointer as an indicator for
whether or not we need to revert or commit the prepared changes.
Simplify this and just use the pointer. If we successfully changed
properties the revert pointer will be NULL and if we failed to change
properties it will indicate where we failed and thus need to stop
reverting.
Link: https://lore.kernel.org/r/20220203131411.3093040-8-brauner@kernel.org
Cc: Seth Forshee <seth.forshee@digitalocean.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions