diff options
| author |   Eric Biggers <ebiggers@google.com> | 2022-01-18 16:54:36 -0800 |
|---|---|---|
| committer |   Jarkko Sakkinen <jarkko@kernel.org> | 2022-03-08 10:33:18 +0200 |
| commit | 8bdc3e05cc78513b7495366ef9b962a3ea568e8e (patch) | |
| tree | 8dfb73d208dd5d44a8904068f325f861fd34ccc2 /crypto | |
| parent | KEYS: x509: remove never-set ->unsupported_key flag (diff) | |
| download | linux-dev-8bdc3e05cc78513b7495366ef9b962a3ea568e8e.tar.xz linux-dev-8bdc3e05cc78513b7495366ef9b962a3ea568e8e.zip | |
KEYS: x509: remove dead code that set ->unsupported_sig
The X.509 parser always sets cert->sig->pkey_algo and
cert->sig->hash_algo on success, since x509_note_sig_algo() is a
mandatory action in the X.509 ASN.1 grammar, and it returns an error if
the signature's algorithm is unknown. Thus, remove the dead code which
handled these fields being NULL.
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/asymmetric_keys/x509_public_key.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index b03d04d78eb9..8c77a297a82d 100644 --- a/crypto/asymmetric_keys/x509_public_key.c +++ b/crypto/asymmetric_keys/x509_public_key.c @@ -33,15 +33,6 @@ int x509_get_sig_params(struct x509_certificate *cert) sig->data = cert->tbs; sig->data_size = cert->tbs_size; - if (!sig->pkey_algo) - cert->unsupported_sig = true; - - /* We check the hash if we can - even if we can't then verify it */ - if (!sig->hash_algo) { - cert->unsupported_sig = true; - return 0; - } - sig->s = kmemdup(cert->raw_sig, cert->raw_sig_size, GFP_KERNEL); if (!sig->s) return -ENOMEM; |