diff options
| author |   Peter Griffin <peter.griffin@linaro.org> | 2015-03-31 08:35:09 +0100 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2015-04-01 12:07:19 -0400 |
| commit | 9a1e75e11a8d09c5cba022e1ac04b0785354f708 (patch) | |
| tree | ede77127c8bd8b125fa3f8737e1679f46b8bf1f8 /drivers/ata/ahci_st.c | |
| parent | ahci: st: Update the ahci_st DT documentation (diff) | |
| download | linux-dev-9a1e75e11a8d09c5cba022e1ac04b0785354f708.tar.xz linux-dev-9a1e75e11a8d09c5cba022e1ac04b0785354f708.zip | |
ahci: st: st_configure_oob must be called after IP is clocked.
Currently the ahci_st driver will hang the system on probe, as the
st_configure_oob function does some register writes before the IP
is clocked. This patch moves the function call to after
ahci_platform_enable_resources (which enables the IP clock), and
resolves the hang.
Addtionally st_ahci_configure_oob should be called in the st_ahci_resume
function, so we also rectify that ensuring it is also called after
the IP clock has been enabled.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/ahci_st.c')
| -rw-r--r-- | drivers/ata/ahci_st.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c index bc971af262e7..ea0ff005b86c 100644 --- a/drivers/ata/ahci_st.c +++ b/drivers/ata/ahci_st.c @@ -68,8 +68,6 @@ static int st_ahci_deassert_resets(struct device *dev) } } - st_ahci_configure_oob(drv_data->hpriv->mmio); - if (drv_data->sw_rst) { err = reset_control_deassert(drv_data->sw_rst); if (err) { @@ -172,6 +170,8 @@ static int st_ahci_probe(struct platform_device *pdev) if (err) return err; + st_ahci_configure_oob(drv_data->hpriv->mmio); + err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info, &ahci_platform_sht); if (err) { @@ -222,6 +222,8 @@ static int st_ahci_resume(struct device *dev) return err; } + st_ahci_configure_oob(drv_data->hpriv->mmio); + return ahci_platform_resume_host(dev); } #endif |