diff options
| author |   Dan Williams <dan.j.williams@intel.com> | 2019-10-15 12:54:17 -0700 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2019-10-15 14:10:19 -0600 |
| commit | 09d6ac8dc51a033ae0043c1fe40b4d02563c2496 (patch) | |
| tree | 7c906b805db024722e48d4d487ffe518a5dd3eab /drivers/ata | |
| parent | blk-rq-qos: fix first node deletion of rq_qos_del() (diff) | |
| download | linux-dev-09d6ac8dc51a033ae0043c1fe40b4d02563c2496.tar.xz linux-dev-09d6ac8dc51a033ae0043c1fe40b4d02563c2496.zip | |
libata/ahci: Fix PCS quirk application
Commit c312ef176399 "libata/ahci: Drop PCS quirk for Denverton and
beyond" got the polarity wrong on the check for which board-ids should
have the quirk applied. The board type board_ahci_pcs7 is defined at the
end of the list such that "pcs7" boards can be special cased in the
future if they need the quirk. All prior Intel board ids "<
board_ahci_pcs7" should proceed with applying the quirk.
Reported-by: Andreas Friedrich <afrie@gmx.net>
Reported-by: Stephen Douthit <stephend@silicom-usa.com>
Fixes: c312ef176399 ("libata/ahci: Drop PCS quirk for Denverton and beyond")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/ahci.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index dd92faf197d5..05c2b32dcc4d 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1600,7 +1600,9 @@ static void ahci_intel_pcs_quirk(struct pci_dev *pdev, struct ahci_host_priv *hp */ if (!id || id->vendor != PCI_VENDOR_ID_INTEL) return; - if (((enum board_ids) id->driver_data) < board_ahci_pcs7) + + /* Skip applying the quirk on Denverton and beyond */ + if (((enum board_ids) id->driver_data) >= board_ahci_pcs7) return; /* |