diff options
| author |   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> | 2018-07-02 12:01:53 -0700 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2018-07-30 10:32:51 -0700 |
| commit | 2dbb3ec29a6c069035857a2fc4c24e80e5dfe3cc (patch) | |
| tree | 30158080c983b8157c4782fbd25f25809e076080 /drivers/ata | |
| parent | ata: ahci: Enable DEVSLP by default on x86 with SLP_S0 (diff) | |
| download | linux-dev-2dbb3ec29a6c069035857a2fc4c24e80e5dfe3cc.tar.xz linux-dev-2dbb3ec29a6c069035857a2fc4c24e80e5dfe3cc.zip | |
ata: libahci: Correct setting of DEVSLP register
We have seen that on some platforms, SATA device never show any DEVSLP
residency. This prevent power gating of SATA IP, which prevent system
to transition to low power mode in systems with SLP_S0 aka modern
standby systems. The PHY logic is off only in DEVSLP not in slumber.
Reference:
https://www.intel.com/content/dam/www/public/us/en/documents/datasheets
/332995-skylake-i-o-platform-datasheet-volume-1.pdf
Section 28.7.6.1
Here driver is trying to do read-modify-write the devslp register. But
not resetting the bits for which this driver will modify values (DITO,
MDAT and DETO). So simply reset those bits before updating to new values.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libahci.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index f79dce613e54..fdb7d7bf7626 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -2162,6 +2162,8 @@ static void ahci_set_aggressive_devslp(struct ata_port *ap, bool sleep) deto = 20; } + /* Make dito, mdat, deto bits to 0s */ + devslp &= ~GENMASK_ULL(24, 2); devslp |= ((dito << PORT_DEVSLP_DITO_OFFSET) | (mdat << PORT_DEVSLP_MDAT_OFFSET) | (deto << PORT_DEVSLP_DETO_OFFSET) | |