diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-15 11:30:14 +0530 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2019-09-19 12:21:44 -0600 |
| commit | d7f76f36a8b4dc8eff0c22819e4a5d55b0dee62a (patch) | |
| tree | e2d5fba6e85021f13d3c9ff8aa44101227512344 /drivers/ata | |
| parent | nbd: fix possible page fault for nbd disk (diff) | |
| download | linux-dev-d7f76f36a8b4dc8eff0c22819e4a5d55b0dee62a.tar.xz linux-dev-d7f76f36a8b4dc8eff0c22819e4a5d55b0dee62a.zip | |
ata: libahci_platform: Add of_node_put() before loop exit
Each iteration of for_each_child_of_node puts the previous node, but
in the case of a goto from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before three such goto
statements.
Issue found with Coccinelle.
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libahci_platform.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c index 9e9583a6bba9..e742780950de 100644 --- a/drivers/ata/libahci_platform.c +++ b/drivers/ata/libahci_platform.c @@ -497,6 +497,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, if (of_property_read_u32(child, "reg", &port)) { rc = -EINVAL; + of_node_put(child); goto err_out; } @@ -514,14 +515,18 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, if (port_dev) { rc = ahci_platform_get_regulator(hpriv, port, &port_dev->dev); - if (rc == -EPROBE_DEFER) + if (rc == -EPROBE_DEFER) { + of_node_put(child); goto err_out; + } } #endif rc = ahci_platform_get_phy(hpriv, port, dev, child); - if (rc) + if (rc) { + of_node_put(child); goto err_out; + } enabled_ports++; } |