diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-02-23 17:47:18 +0200 |
|---|---|---|
| committer |   Miguel Ojeda <ojeda@kernel.org> | 2022-03-03 00:30:31 +0100 |
| commit | 9ed331f8a0fb674f4f06edf05a1687bf755af27b (patch) | |
| tree | 58387ee9ec6cf300bcac857aa2820ebd827ade8a /drivers/auxdisplay | |
| parent | auxdisplay: lcd2s: Fix memory leak in ->remove() (diff) | |
| download | linux-dev-9ed331f8a0fb674f4f06edf05a1687bf755af27b.tar.xz linux-dev-9ed331f8a0fb674f4f06edf05a1687bf755af27b.zip | |
auxdisplay: lcd2s: Use proper API to free the instance of charlcd object
While it might work, the current approach is fragile in a few ways:
- whenever members in the structure are shuffled, the pointer will be wrong
- the resource freeing may include more than covered by kfree()
Fix this by using charlcd_free() call instead of kfree().
Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'drivers/auxdisplay')
| -rw-r--r-- | drivers/auxdisplay/lcd2s.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c index 7b9cfbbaf007..2578b2d45439 100644 --- a/drivers/auxdisplay/lcd2s.c +++ b/drivers/auxdisplay/lcd2s.c @@ -336,7 +336,7 @@ static int lcd2s_i2c_probe(struct i2c_client *i2c, return 0; fail1: - kfree(lcd); + charlcd_free(lcd2s->charlcd); return err; } @@ -345,7 +345,7 @@ static int lcd2s_i2c_remove(struct i2c_client *i2c) struct lcd2s_data *lcd2s = i2c_get_clientdata(i2c); charlcd_unregister(lcd2s->charlcd); - kfree(lcd2s->charlcd); + charlcd_free(lcd2s->charlcd); return 0; } |