diff options
| author |   Ming Lei <ming.lei@canonical.com> | 2012-08-04 12:01:18 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-16 13:13:18 -0700 |
| commit | 0c25a850f7f336cd3bf2b0a479fe70cecb242c6e (patch) | |
| tree | 8fc24e5da84b52cff49ae11150bd90d6b0bb20e9 /drivers/base/firmware_class.c | |
| parent | firmware loader: fix races during loading firmware (diff) | |
| download | linux-dev-0c25a850f7f336cd3bf2b0a479fe70cecb242c6e.tar.xz linux-dev-0c25a850f7f336cd3bf2b0a479fe70cecb242c6e.zip | |
firmware loader: remove unnecessary wmb()
The wmb() inside fw_load_abort is not necessary, since
complete() and wait_on_completion() has implied one pair
of memory barrier.
Also wmb() isn't a correct usage, so just remove it.
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/firmware_class.c')
| -rw-r--r-- | drivers/base/firmware_class.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 1915ad821688..0bd09c7545c9 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -112,7 +112,6 @@ static struct firmware_priv *to_firmware_priv(struct device *dev) static void fw_load_abort(struct firmware_priv *fw_priv) { set_bit(FW_STATUS_ABORT, &fw_priv->status); - wmb(); complete(&fw_priv->completion); } |